-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swi-prolog-devel: Updated to version 9.1.17 #20918
Conversation
@JanWielemaker I noticed that the build fails on macOS < 10.10 (see for example, this log). Perhaps doing so would allow the package to build for older systems as well? Or is there another reason from the linked log file that would prohibit this anyway? |
Thanks for the comments.
Yes. That is not version 9.1.17 though, but for quite some time.
No. C11 is really required. The code base notably uses the C11 Generic construct. This made the code simpler and more robust. Note that the C++ binding requires C++-17 (which we could ditch if not available) and the (new) Python binding requires thead local storage. If there are strong reasons not to demand TLS we could of course replace that by pthread primitives as we also do for the core (we use native TLS when available and pthread otherwise) P.s. Ideally we'd use GCC (the real one) and Could you make these changes to the Portfile? |
okay, so from a quick read we should request a compiler that supports: C11, CXX17, and thread-local storage for it to build. There are Portfile directives for all of those, which will pick a MacPorts provided Clang that supports those, installs that first and then compiles the port. I can make these changes and see if that fixes the build on older OSes. Regarding GCC, that is certainly possible and there are Portfiles that provide these compilers as variants. You could take a look at those and/or read through the Wiki link I posted - hopefully most of this is explained there. However, that is more work than I am willing to out in given that I'm not even using the package ;) |
Thanks!
Thanks for the pointers. Might have a look at that later. It seems much less a problem on Apple Silicon, so just waiting long enough also helps 😄 |
@JanWielemaker I added the things discussed here to the |
If applicable, we ("royal we", meaning you) could add the same to the |
Thanks! I guess the next swi-prolog update will be for the next stable cycle (9.2.0). Can take a while. |
Description
Type(s)
Tested on
macOS 13.4.1 22F770820d arm64
Xcode 14.3.1 14E300c
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?